-
-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] stock_picking_batch_extended_account_sale_type: Migration to version 15.0 #1157
[15.0][MIG] stock_picking_batch_extended_account_sale_type: Migration to version 15.0 #1157
Conversation
50491f7
to
1721313
Compare
/ocabot migration stock_picking_batch_extended_account_sale_type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review. Minor change
_inherit = "stock.picking.batch" | ||
|
||
def _get_domain_picking_to_invoice(self): | ||
domain = super(StockBatchPicking, self)._get_domain_picking_to_invoice() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain = super(StockBatchPicking, self)._get_domain_picking_to_invoice() | |
domain = super()._get_domain_picking_to_invoice() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Done!!
@sergio-teruel To help reviewers test with runboat, you can include your dependency in test-requirements.txt file (in a separate commit) |
Hi @rousseldenis How can I do it? Thanks |
60cf3a1
to
8e64d6c
Compare
It follows pip requirements format. You can check this one for example: For instance, it is composed by :
|
@rousseldenis Thanks for the info!! great!! in next PR I will try this... 👍 |
8e64d6c
to
69d3d6d
Compare
Rebase done!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
/ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at b57f1cf. Thanks a lot for contributing to OCA. ❤️ |
I have created this wiki entry to reflect about how to do this: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s) Please do any comment you think to improve it. |
cc @Tecnativa TT40156
Depends on:
ping @carlosdauden @ernestotejeda